search

stolostron / klusterlet-addon-controller

Apache License 2.0
4 stars 22 forks source link

remove finalizer from managedCluster to fix the issue 21837 #122

Closed zhiweiyin318 closed 2 years ago

zhiweiyin318 commented 2 years ago

Signed-off-by: Zhiwei Yin zyin@redhat.com fix the issue https://github.com/stolostron/backlog/issues/21837 fix the error logs caused by empty annotation

zhiweiyin318 commented 2 years ago

/hold

zhiweiyin318 commented 2 years ago

/unhold

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

62.2% 62.2% Coverage
0.0% 0.0% Duplication

zhujian7 commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhiweiyin318, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/klusterlet-addon-controller/blob/main/OWNERS)~~ [zhiweiyin318] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment