search

stolostron / klusterlet-addon-controller

Apache License 2.0
4 stars 22 forks source link

add an annotation to prevent addon config creation #144

Closed zhujian7 closed 2 years ago

zhujian7 commented 2 years ago

Signed-off-by: zhujian jiazhu@redhat.com

Will not automatically create klusterlet addon config for cluster which has addon.open-cluster-management.io/disable-automatic-installation: "true" annotation

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

zhujian7 commented 2 years ago

cc @zhiweiyin318 @elgnay @xuezhaojun

xuezhaojun commented 2 years ago

/lgtm

zhiweiyin318 commented 2 years ago

/approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xuezhaojun, zhiweiyin318, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/klusterlet-addon-controller/blob/main/OWNERS)~~ [zhiweiyin318] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment