search

stolostron / klusterlet-addon-controller

Apache License 2.0
4 stars 22 forks source link

upgrade lib to support ocp4.14 #209

Closed zhiweiyin318 closed 1 year ago

zhiweiyin318 commented 1 year ago

issue: https://issues.redhat.com/browse/ACM-6878

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

zhiweiyin318 commented 1 year ago

/cherry-pick release-2.8

openshift-cherrypick-robot commented 1 year ago

@zhiweiyin318: once the present PR merges, I will cherry-pick it on top of release-2.8 in a new PR and assign it to you.

In response to [this](https://github.com/stolostron/klusterlet-addon-controller/pull/209#issuecomment-1672759411): >/cherry-pick release-2.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
elgnay commented 1 year ago

/lgtm

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/klusterlet-addon-controller/blob/main/OWNERS)~~ [elgnay,zhiweiyin318] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-cherrypick-robot commented 1 year ago

@zhiweiyin318: new pull request created: #210

In response to [this](https://github.com/stolostron/klusterlet-addon-controller/pull/209#issuecomment-1672759411): >/cherry-pick release-2.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.