search

stolostron / klusterlet-addon-controller

Apache License 2.0
4 stars 22 forks source link

Remove the IAM Policy Controller #227

Closed yiraeChristineKim closed 5 months ago

yiraeChristineKim commented 6 months ago

Ref: https://issues.redhat.com/browse/ACM-10859

openshift-ci[bot] commented 6 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

dhaiducek commented 6 months ago

Please add the Jira to the commit message for traceability.

yiraeChristineKim commented 6 months ago

Please add the Jira to the commit message for traceability.

Curios how did you know I opened this pr

dhaiducek commented 6 months ago

Curious how did you know I opened this pr

😬 I had sent you all those links, so I was curious to see how the PR had panned out, haha!

dhaiducek commented 6 months ago

Looks like it was a fair bit more work than I'd expect with all the test changes!

yiraeChristineKim commented 6 months ago

Looks like it was a fair bit more work than I'd expect with all the test changes!

I thought it would be simple too

yiraeChristineKim commented 6 months ago

/cc @dhaiducek @mprahl

mprahl commented 6 months ago

@yiraeChristineKim so this will stop managing the ManagedClusterAddOn objects related to the iam-policy-controller and then you'll delete the ClusterManagementAddOn in multiclusterhub-operator?

yiraeChristineKim commented 6 months ago

@yiraeChristineKim so this will stop managing the ManagedClusterAddOn objects related to the iam-policy-controller and then you'll delete the ClusterManagementAddOn in multiclusterhub-operator?

Correct https://github.com/stolostron/multiclusterhub-operator/pull/1466 this PR will delete cma and current https://github.com/stolostron/klusterlet-addon-controller/pull/227 PR will delete mca

yiraeChristineKim commented 5 months ago

/cc @zhiweiyin318

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

zhiweiyin318 commented 5 months ago

/approve

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, mprahl, yiraeChristineKim, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/klusterlet-addon-controller/blob/main/OWNERS)~~ [zhiweiyin318] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment