search

stolostron / klusterlet-addon-controller

Apache License 2.0
4 stars 22 forks source link

upgrade go to 1.17 #74

Closed zhiweiyin318 closed 2 years ago

zhiweiyin318 commented 2 years ago

issue: https://github.com/open-cluster-management/backlog/issues/15570 Signed-off-by: Zhiwei Yin zyin@redhat.com

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

zhiweiyin318 commented 2 years ago

/cherry-pick release-2.4

openshift-cherrypick-robot commented 2 years ago

@zhiweiyin318: once the present PR merges, I will cherry-pick it on top of release-2.4 in a new PR and assign it to you.

In response to [this](https://github.com/open-cluster-management/klusterlet-addon-controller/pull/74#issuecomment-976473139): >/cherry-pick release-2.4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
elgnay commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management/klusterlet-addon-controller/blob/main/OWNERS)~~ [elgnay,zhiweiyin318] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zhiweiyin318 commented 2 years ago

/retest

openshift-cherrypick-robot commented 2 years ago

@zhiweiyin318: new pull request created: #75

In response to [this](https://github.com/open-cluster-management/klusterlet-addon-controller/pull/74#issuecomment-976473139): >/cherry-pick release-2.4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.