search

stoogoff / sw-adversaries

A simple web app for looking up adversaries for the FFG's Star Wars RPG.
http://swa.stoogoff.com/
68 stars 27 forks source link

Melee / Brawl weapon damage bug when creating/copying custom adversaries #34

Closed AusRabbit closed 2 years ago

AusRabbit commented 3 years ago

Love the product - you lot are champions.

I've just started making my own adversaries using sw-adversaries, often by copying one that is already present. I see the damage calculation against melee/brawl weapons is bugged. A simple truncheon (which might be +2 damage) is originally represented as 5 damage on the adversary. When I copy it and make changes such weapons display as 22 damage. This is clearly out of whack with the adversaries brawn and weapon details?

Wondering if that's something you might want to fix?

image

stoogoff commented 3 years ago

If I add a truncheon to a character but don't change their Brawn value then it works correctly. If I change the Brawn value then it displays as you describe. So it's Javascript treating the Brawn value as a string not as a number.

Thanks for bringing that to my attention, I'll get that fixed.

AusRabbit commented 3 years ago

Amazing!

Thanks dude. I love this game and you make it possible.

Cheers, Rabs

Get Outlook for iOShttps://aka.ms/o0ukef

From: Stoo @.> Sent: Wednesday, October 20, 2021 6:27:50 PM To: stoogoff/sw-adversaries @.> Cc: AusRabbit @.>; Author @.> Subject: Re: [stoogoff/sw-adversaries] Melee / Brawl weapon damage bug when creating/copying custom adversaries (Issue #34)

If I add a truncheon to a character but don't change their Brawn value then it works correctly. If I change the Brawn value then it displays as you describe. So it's Javascript treating the Brawn value as a string not as a number.

Thanks for bringing that to my attention, I'll get that fixed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/stoogoff/sw-adversaries/issues/34#issuecomment-947401472, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWEJCJWRPJUP4WIOGZYUQG3UHZVPNANCNFSM5GKQCHSA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.