search

stoogoff / sw-adversaries

A simple web app for looking up adversaries for the FFG's Star Wars RPG.
http://swa.stoogoff.com/
68 stars 27 forks source link

Beyond the Rim NPC's #8

Closed nlx3647 closed 7 years ago

nlx3647 commented 7 years ago

All the NPC's have been added, gulp live build done, and successful.

stoogoff commented 7 years ago

I've got a list of things which need to be fixed below. Most of them are general formatting rules, which I'm going to add to the readme so they're available for reference. What I'm also going to do is fix all of these issues as you've done a lot of good work here and it would be good to get it live and on the site.

General formatting stuff:

tags which aren't menu tags (i.e. ones without a colon in, so not species:... adventure:... etc) should be lower case. The exception to this is droid manufacturers as company names. So:

tag Creature should be creature tag Empire should be empire

Ranges are always first letter capital in descriptions so Medium, Long, never medium.

Same with Soak and Defence.

I'd prefer British spelling, so armour, colour, defence wherever possible. The exception to this names, so talents and abilities keep the names they have in the books.

All equipment and weapon names should be first letter capital with subsequent words all lower case, so Blaster rifle, Heavy blaster rifle. The exception to this is a weapon name or ID which should remain capitalised, e.g. TT24 Holdout blaster.

All descriptions should be formatted as a regular sentence, so they should start with a capital letter and end in a full stop.

When adding dice pools to descriptions you can do :average:, :hard: etc, rather than typing out each dice. Unfortunately, this doesn't work for upgraded difficulties.

There's a qualities/mods.json file for weapon mods, which would be a better place for attachments.

If a talent, weapon or ability is going to be used in multiple places and it has the same stats, then put the details in the appropriate file rather than copying and pasting it.

On-board processor isn't a talent so shouldn't be in talents.json. It's listed as equipment in the book.

Most importantly: check your work! There are areas where weapons aren't showing up because the text casing is wrong, e.g. the Blaster rifle for the Rebel Liaison.