search

stoplightio / json-schema-tree

Apache License 2.0
12 stars 7 forks source link

chore: various improvements #5

Closed P0lip closed 3 years ago

P0lip commented 3 years ago

Addresses some of my findings from https://github.com/stoplightio/json-schema-viewer/pull/109

I suggest to review the PR commit by commit (I'll probably do a rebase rather than squash)

Suggest to enable image

P0lip commented 3 years ago

Ah, hold on. I didn't mean to ask for review you yet. Will wait for merge-allof PR to be merged.

P0lip commented 3 years ago

it doesn't have any impact, but it's just no longer needed. At the time I wrote it I assumed that at times we might need to produced a few nodes for a single fragment, but we don't seem to.

P0lip commented 3 years ago

I'll move the following 0e5dcf2 commit out of this PR to reduce the noise.

domagojk commented 3 years ago

I'm pretty much in the same boat as @paulatulis. Changes look good to me, but I'm also lacking context. It's hard to figure out what findings exactly are you addressing and why and how to test it since I haven't really worked much with neither JSV or JST.

And this seems like a small chore PR, so maybe not the best "getting started candidate" to dive into it and learn about it? I'm not sure 😳

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.0.1-beta.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: