search

strawberrymusicplayer / strawberry

:strawberry: Strawberry Music Player
https://www.strawberrymusicplayer.org/
GNU General Public License v3.0
2.68k stars 184 forks source link

Albums combined even if different Album Artist #1276

Closed dbolton closed 3 months ago

dbolton commented 1 year ago

Describe the bug A two-part bug:

First, Strawberry combines albums with the same Album Title, even if they have different Album Artists.

Second, after I edit the Album titles to work around this, Strawberry Player didn't automatically update.

To Reproduce I have a three CD set called "Celebrating The Best of Jazz". The Louis Armstrong CD shows as it's own album (presumably because of the uppercase "Of"). The Duke Ellington and Count Basie CDs show as one combined album. image

In an attempt to separate all three I relabeled the Album Title (using foobar2000 music player, since it let me see and edit the individual albums)

Expected image First, I would expect the three albums to show separately before the renaming (since they had different Album Artists). In broad case of separate Artists releasing albums with the same title, Strawberry shouldn't combine them if the Album Artist is different.

Second, I would expect to automatically see the new Album Titles in Strawberry player after editing them.

Actual I didn't see the Album Title automatically change in Strawberry (even after closing and reopening the Player multiple times).

My settings are checked for "Update the collection when Strawberry starts" and "Monitor the collection for changes."

Workaround First, I relabeled the Album Titles so they were distinct.

Second, to fix the metadata, I selected Tools > Do a full collection rescan

System Information:

jonaski commented 1 year ago

What is collection group by set to?

dbolton commented 1 year ago

Applies to the following

As a workaround, Strawberry correctly separates the albums in "Group by Album Artist/Album - Disc"

For comparison, here's the Album views in other media players:

Windows Media Player image

Jellyfin image

foobar2000 image

For reference, here's meta data for each Album. (Note Strawberry is one of the few that correctly pulls the front cover art instead of the back cover art). image

image

image

TheJanzap commented 1 year ago

I have a similar bug: When I select "Group by Album Artist/Year - Album" all albums that share the same name but with different album artists are listed under "Various artists".

Example: Both Blur and Die Ärzte have released albums titled "13". They are both listed under "Various Artists", even though their Album Artist tag is set to Blur and Die Ärzte respectively. The "Compilation" checkbox is also unset on both albums. image

dbolton commented 1 year ago

@TheJanzap I'm not able to reproduce what your describing. Do you have "Album artist" specified as "Blur" and "Die Ärzte" for every track on the respective albums (and not just the "Artist")?

TheJanzap commented 1 year ago

@dbolton Yes, all tracks on both albums have both the "Album Artist" and "Artist" tags set to their respective artist. All tags are distinct, except the album title. image

jonaski commented 12 months ago

@TheJanzap That's not a bug, but expected behavior. If there are albums with the same album name, but different artists in the same directory, automatic compilation detection kicks in and it's grouped under various artists. I'm not sure why you have different album artists for the same album, usually the album artist for the album should be the same, but artist different. You can override the compilation detected by right clicking on the album and select "Don't show in various artists".

TheJanzap commented 11 months ago

@jonaski

If there are albums with the same album name, but different artists in the same directory, automatic compilation detection kicks in and it's grouped under various artists.

I understand why it's done this way, but the way my tags are configured this really isn't needed. I only want albums showing up under Various Artists if the album artist is set to Various Artists. Is there a way to disable auto compilation detection globally without having to mark every album with "Don't show in various artists"?

I'm not sure why you have different album artists for the same album, usually the album artist for the album should be the same, but artist different.

My tags are exactly how you describe them: The album artist is the same across an album with sometimes differing artist tags for featured artists.

jonaski commented 6 months ago

This isn't fixable with the current model, and album only groupings aren't currently loading well without lagging the entire GUI anyway, I will try to address this instead as part of a major rewrite in #729.

jonaski commented 3 months ago

This is fixed now, if you group by album at the first level, it will separate albums if they have different artist, I've also added an option to turn off "Various artists".

sonic2kk commented 2 months ago

Is there a way to restore the previous behaviour? That is to actually group album artists? I absolutely see the value in separating them, but wondering if there is a way to go back. I have been fiddling with the Advanced Grouping options for a while and can't find a way to restore the old behaviour.

This behaviour may be undesirable in some cases for some users. For example, where each disc of a video game soundtrack has a different album artist. The album will have the same name, so the album effectively shows up twice. This is a fine and sensible default but if there is a way to go back to the old behaviour of having albums grouped unconditionally regardless of disc, artist, or any other criteria, that is that I want the album to show up as a single entry regardless of any other factor, I would be glad to know how I can configure the Advanced Grouping to do this.

For collections like in the OP is makes sense, but at least for my tastes and how I prefer my albums organised (and a significant amount of what I own are soundtracks from Steam), I preferred the old behaviour. I'm not advocating for it to be the default again, just wondering if there's a way I can configure Strawberry to do it.

I should point out that some of this is down to possibly odd metadata (the Broforce soundtrack only has one track with a different album artist, the To the Moon soundtrack has a couple tracks where the Album Artist varies so it shows up as three entries) but in other cases each disc of the same soundtrack has a different album artist, so having them show up separately is a little odd to me.