strawberrymusicplayer / strawberry

:strawberry: Strawberry Music Player
https://www.strawberrymusicplayer.org/
GNU General Public License v3.0
2.53k stars 164 forks source link

Attempting to rename an Extended Module (XM) file causes an error to show, even if renamed successfully. #1413

Closed DexrnZacAttack closed 2 months ago

DexrnZacAttack commented 2 months ago

Describe the bug Attempting to change the title of an XM file causes an error to pop up despite it renaming successfully... additionally, there is not a 20 (or is it 18 since padded with spaces?) character limit put in place to prevent long names getting truncated.

To Reproduce Import an XM file into Strawberry, right click on the title, and attempt to rename it.

Expected behavior It should not show an error unless there is actually an issue, and it shouldn't let me type more than 20 characters.

Screenshots: Header before rename HxD -  FHomeMusicFormatsXMDubmood - Insert No Coins xm  2_b1 Error while trying to rename Strawberry Error - Strawberry Music Player 1_b1 New file name, despite Strawberry throwing an error. HxD -  FHomeMusicFormatsXMDubmood - Insert No Coins xm _b1

System Information:

Additional context Strawberry also fails to show the new name after renaming, forcing me to rescan the song.

jonaski commented 2 months ago

Strawberry does not support writing tags to XM format, or any other game format. I'm not sure how you tried to rename the file?

DexrnZacAttack commented 2 months ago

Strawberry does not support writing tags to XM format, or any other game format. I'm not sure how you tried to rename the file?

I right clicked Title, clicked "Edit tag Title", and typed a new name...