strawberrymusicplayer / strawberry

:strawberry: Strawberry Music Player
https://www.strawberrymusicplayer.org/
GNU General Public License v3.0
2.53k stars 164 forks source link

Playlists are broken and empty after latest commits #1430

Closed nokia8801 closed 2 months ago

nokia8801 commented 2 months ago

Describe the bug Playlists are broken and empty after the latest commits. The tracks are still there but they have no information about them and can't be played.

To Reproduce Clone the repo and compile from master.

Expected behavior Should be visible and working like before. It was working with version 1.0.23.r116.gc30a39d2-1 which would be commit c30a39d29a65d027e04d0b2858481077d68fe7c5.

Screenshots: image

System Information:

Additional context Not every playlist is broken like this for some reason, but more than half are empty. Either it is random or there is something I'm not understanding. But downloading normal 1.0.23 from official Arch repositories fixes the issue so it must be one the recent commits, probably between ac0926d40b94d752a6b3bd29ac6f417c5de0ecb8 and 5f9a83871de341fc3f1c5d0eff627dfdfad653fb (including them) cause it first broke with commit 5f9a83871de341fc3f1c5d0eff627dfdfad653fb and is still broken even with the latest commits.

jonaski commented 2 months ago

Thanks, I see the col position is wrong, will look into it.

jonaski commented 2 months ago

The position was wrong when loading streams and songs outside of the collection. Should be fixed now, but your playlists will probably already be wiped so you need to recreate them.

nokia8801 commented 2 months ago

Should be fixed now, but your playlists will probably already be wiped so you need to recreate them.

@jonaski Downgrading to regular 1.0.23 brought them back somehow. I just compiled strawberry-git again and local songs are back to normal but url streams are still broken and can't be played. They're completely empty and when I click them I get:

Invalid URI "".

../gstreamer/subprojects/gst-plugins-base/gst/playback/gsturisourcebin.c(1683): gen_source_element (): /GstPlayBin3:pipeline-3-pipeline/GstURIDecodeBin3:uridecodebin3/GstURISourceBin:urisourcebin2

Edit: Nevermind, added them again and everything is fine, they must be broken leftovers from the previous commits. Thanks again.

Edit: Actually, do not nevermind. After closing the app and reopening it, the URL streams break again. They're empty and can't played.

jonaski commented 2 months ago

I forgot that radio streams has it's own playlist item type, fixed now.

cmorgenstern commented 1 month ago

Sorry to necro-bump, but I don't think this has been resolved. Using the latest version of Strawberry compiled from master, playlists with local files do not correctly display, and I cannot save and load playlists either (M3U).

Describe the bug Local tracks in playlists are not correctly linked to library items. Loading a newly saved M3U playlist also produces the same result.

To Reproduce 1) Open Strawberry 2) Open an M3U playlist containing local track

Expected: Playlist loads with the entries linked to tracks in the library

Actual: Playlist entries are not linked and cannot be played.

1) Open Strawberry 2) Create a new playlist and and add some tracks 3) Save the playlist (.m3u) and close it 4) Load the saved playlist

Expected: Playlist loads with the entries linked to tracks in the library

Actual: Playlist entries are not linked and cannot be played.

System Information: