strawberrymusicplayer / strawberry

:strawberry: Strawberry Music Player
https://www.strawberrymusicplayer.org/
GNU General Public License v3.0
2.53k stars 164 forks source link

Player controls and seek bar are not updated, possible signal connection problem #1450

Closed martenjj closed 4 weeks ago

martenjj commented 4 weeks ago

Describe the bug This refers to a problem with Strawberry version 1.0.23 on Gentoo using Qt 5 (a Qt 6 build is not yet available). It was originally reported as #1283 and said to be fixed, but it still appears to be present in this build. Media will play, but the player controls and seek bar are not enabled or updated, and messages are seen in the debug log:

WARN unknown QObject::connect: Cannot queue arguments of type 'State' WARN unknown (Make sure 'State' is registered using qRegisterMetaType().)

To Reproduce Start to play a media file, for example by dragging a track to the playlist and then double-clicking it. Observe that the "play" button does not change to "pause" and the seek bar does not move. Click on "play" or "stop" and observe that nothing happens.

Expected behavior The player controls and seek bar should reflect the current state.

System Information:

Additional context The patch here appears to fix the problem. The warning messages are not seen, the player controls change state as expected and can be used. GitHub doesn't seem to want to attach the patch file here, but it can be found at https://bugs.gentoo.org/attachment.cgi?id=893156 or attached to Gentoo bug: https://bugs.gentoo.org/show_bug.cgi?id=915020

jonaski commented 4 weeks ago

Didn't I just fix this? d7cc52b

jonaski commented 4 weeks ago

The patch from the Gentoo issue is the same thing I just fixed.