strawberrymusicplayer / strawberry

:strawberry: Strawberry Music Player
https://www.strawberrymusicplayer.org/
GNU General Public License v3.0
2.63k stars 177 forks source link

Fasttracker II files (.xm files, chiptune musics) can't be played on latest release #1479

Closed XutaxKamay closed 2 weeks ago

XutaxKamay commented 2 months ago

Describe the bug Fasttracker II files (.xm files, chiptune musics) can't be played if playbin3 is taken since release 1.0.23.

This commit solves the issue though https://github.com/strawberrymusicplayer/strawberry/commit/8a27c6a52ffce63c5c7ae058ea3966bdf6543bc6#diff-7ffc8ab9614f3dc88e94916de48ffdd37e1ff0b1a1dfffd94a618896e6c4840c but I'm afraid there is probably some regressions on gstreamer even on 1.24, I haven't tested.

To Reproduce Build 1.0.23 release, play xm chiptune => gstreamer (1.22) says that it is not supported.

Expected behavior The chiptune should play as it did before.

Screenshots: N/A

System Information:

Additional context This will be solved on next release, but I thought it may have been important to track the issue here. For now I'm using a patch to fix the issue.

jonaski commented 2 months ago

Strawberry does have many issues with 1.22. Test with GStreamer 1.24, if you still can reproduce it we need a gstreamer debug log so it can be reported to GStreamer.

XutaxKamay commented 2 months ago

Strawberry does have many issues with 1.22. Test with GStreamer 1.24, if you still can reproduce it we need a gstreamer debug log so it can be reported to GStreamer.

I just tested with gstreamer 1.24.5 (including plugins, the relevant one should be modplug), I get the same issue. (master branch this time)

Here is a log with GST_DEBUG=5

log.txt

jonaski commented 1 month ago

I don't think modplug works very well anymore, the library hasn't been updated for years, I didn't even know distros were building gstreamer with modplug anymore. You should probably use openmpt (libgstopenmpt.so) instead (part of gst-plugins-bad). It plays XM fine here using opempt. Check if you got it with: gst-inspect-1.0 openmpt

XutaxKamay commented 1 month ago

I don't think modplug works very well anymore, the library hasn't been updated for years, I didn't even know distros were building gstreamer with modplug anymore. You should probably use openmpt (libgstopenmpt.so) instead (part of gst-plugins-bad). It plays XM fine here using opempt. Check if you got it with: gst-inspect-1.0 openmpt

Seems like my distro doesn't even have openmptdec plugin in its repo, no worries though I'll create an ebuild for it and check if it works Thank you

jonaski commented 3 weeks ago

Reported this here: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3722