strawberrymusicplayer / strawberry

:strawberry: Strawberry Music Player
https://www.strawberrymusicplayer.org/
GNU General Public License v3.0
2.74k stars 192 forks source link

Contextual searches no longer substituting selected container value #1510

Closed JacobHenner closed 3 months ago

JacobHenner commented 3 months ago

Describe the bug The feature added in https://github.com/strawberrymusicplayer/strawberry/pull/1346 (contextual searching) was broken between the time it was added, and the time of the latest release.

If a track is selected in the collection view and the user opens the context menu and selects Search for this, the collection search will properly be set to title:$title. If an album, artist, or other containers are selected and the same steps are followed, search will be improperly set to $fieldname: (note the actual value is missing).

To Reproduce

  1. Pick album, artist, or similar in collection view
  2. Select Search for this in context menu
  3. Observe value of search field

Expected behavior

The search should have included both the field name and the field's value.

System Information:

Additional context

I will try to address this if I find time, but I've been quite busy lately and might not be able to address in the immediate future.