Windows gstspotify.dll missing in strawberry-msvc-dependencies releases

strawberrymusicplayer / strawberry

:strawberry: Strawberry Music Player

https://www.strawberrymusicplayer.org/

GNU General Public License v3.0

2.71k stars 191 forks source link

Windows gstspotify.dll missing in strawberry-msvc-dependencies releases #1587

Closed Erriez closed 4 hours ago

Erriez commented 4 hours ago

Describe the bug The Windows NSIS installer strawberry.nsi.in contains a reference to gstspotify.dll which is not included in the MSVC binaries.

To Reproduce Generate NSIS installer from generated strawberry.nsi cannot find gstspotify.dll using strawberry-msvc-x86_64-debug.tar.xz or strawberry-msvc-x86_64-release.tar.xz.

Expected behavior gstspotify.dll included in the tar.xz binaries.

Screenshots: N.A.

System Information:

Operating system: Windows
Strawberry Version: strawberry-msvc-dependencies 180fda1

Additional context N.A.

jonaski commented 4 hours ago

Spotify is disabled because it doesn't currently build.

Erriez commented 16 minutes ago

Thanks for your confirmation. I could not apply the patch as described on https://wiki.strawberrymusicplayer.org/wiki/Installing_GStreamer_Spotify_plugin, so that confirms build issues.

No problem, it can be disabled with ENABLE_SPOTIFY for the time being. NSIS strawberry.nsi.in should be manually commented out at two places for install and uninstall.

jonaski commented 10 minutes ago

The patch isn't necessary because the MR has been merged to main, I've removed it now. But I still couldn't build it, you can add back gst-plugins-rs in build.bat if you want to try, but you need to install rust and rustc.