strawberrymusicplayer / strawberry

:strawberry: Strawberry Music Player
https://www.strawberrymusicplayer.org/
GNU General Public License v3.0
2.74k stars 191 forks source link

Songs from album doubled in collection #902

Closed Meowserita closed 2 years ago

Meowserita commented 2 years ago

For technical issues, questions and feature suggestions/requests please use the forum on https://forum.strawberrymusicplayer.org/

Check the Changelog to see if the issue is already fixed: https://github.com/strawberrymusicplayer/strawberry/blob/master/Changelog

If it's fixed, try the latest development build from: https://builds.strawberrymusicplayer.org/

Describe the bug songs of one specific album are duplicated in strawberry.

To Reproduce this is probably not gonna be possible to duplicate one your end, but for me its as simple as delete the album, refresh collection in strawberry close strawberry, copy DISSIDENTE - ДИССИДЕНТЫ - The War on Two Fronts.zip to my music folder extract the zip, delete the zip and launch strawberry.

Expected behavior expect the album to appear in strawberry with one copy of each song,

Screenshots: war on two fronts duplicated war on two fronts files

System Information:

Additional context this is probably not gonna be possible to reproduce on your end as its literally this one specific zip causing problems, i delete and re add another album (catbite - nice one for context) following the exact same steps and it doesnt duplicate in strawberry. delete and download the problem album off bandcamp and follow the steps and it does duplicate. my best bet is it might be something specific to either the album or the artist possibly the cyrillic in the bands name but that doesnt really make sense to me, so really no clue at all.

jonaski commented 2 years ago

Is "Song fingerprinting and tracking" on or off in the collection settings? If it's off, is the "Mark disappeared songs unavailable" on or off?

Meowserita commented 2 years ago

song fingerprinting and tracking is off and mark disappeared songs unavailable is on.

evilsh3ll commented 2 years ago

I have the same problem (in Arch Linux, Strawberry 1.0.4) with song fingerprinting and tracking on or off and disappeared songs unavailable on or off: there is no difference. If this can be useful this is an example of two version of the same album: image they are merged in one single CD in Strawberry: image

Feel free to ask any additional information, if I can help.

ccritter commented 2 years ago

Same issue, Windows 10, Strawberry 1.0.4. Can also provide info if needed.

evilsh3ll commented 2 years ago

the same problem is also in latest Clementine build, so I opened an issue in its github repository too

jonaski commented 2 years ago

If you have more than one file with the same artist, album and song title then it will show two times, that's not a bug (even with fingerprinting on). You could separate them by appending something to one of them album tiles, like expanded, deluxe, etc.

evilsh3ll commented 2 years ago

Folder name is different, and they are in different paths. Changing the metadata name of the album it's not correct in my opinion because the name of the album shouldn't contain the album flavor ("expanded", "Japanese"), just like MusicBrainz database does. 1

There are other albums with same album name, same artist and (not all) same songs but in different positions (see screenshot below), that are correctly separated in different albums. Why? 2 image

Do you know if there are other ways to separate them other than changing metadata? Lollypop player can separate albums with same artist,name and song, even if they are in the same folder, I don't know how, maybe it uses other metadata.

jonaski commented 2 years ago

The grouping tag can separate two albums with the same album title, but Strawberry only uses the grouping tag when using year - album (disc) grouping, not sure if I remember why I didn't use the grouping tag for normal album grouping without year. But it has been like that for a long as I can remember. Anyway, this has nothing to do with the original bug which was about a specific album being duplicated in the collection.

ccritter commented 2 years ago

I just took a look at my DB and for albums that are duplicated, each song in the songs table has two completely identical rows (aside from the ID). I'm not set up with this repo to debug, but if I were, I'd put a breakpoint here and take a look at the callstack to see why we're getting here twice. I hit this very very frequently, nearly every album I import gets duplicated:

  1. Drag some unimported files into a playlist, maybe have multiple albums as a better test. Not sure if also important, but most of the music I'm importing comes from Bandcamp (you can easily find some free albums to test with)
  2. Select all, right click, "Move to Collection"
  3. Import them. I'm using the naming scheme %albumartist/%album/{%track - }%title.%extension, and enabling: "Remove problematic characters", "Restrict characters to ASCII", "Copy album cover artwork"
  4. See duplicates in the Collection

Just today I imported 7 albums, and 4.5 of them got duplicated (only half the songs on one was duped).

jonaski commented 2 years ago

@ccritter That's probably directly related to the organizing, different issue than the original bug report. Even though I could not reproduce it, here is a possible fix https://github.com/strawberrymusicplayer/strawberry/commit/dc1f9edfaf60e51568454ebe9c4e04aacb7f19b7

I could not reproduce the original bug reported to by @Meowserita, even when creating files and tags with the same name.

jonaski commented 2 years ago

Closing this as I can't reproduce any more issues related to duplicated songs.

manofsticks commented 1 year ago

I am also having this issue, but I have not been able to find any rhyme or reason to when/why it happens. In my experience, hitting "organize" a couple times will eventually fix it after 1 or 2 organizes.

azumukupoe commented 1 year ago

I was able to fix it by removing the folder from the collection then adding back to it

manofsticks commented 1 year ago

This is still a frequent issue I have when using "Move to Collection" from the files tab. My fix is still to do "Organize Files", which seems to (usually) clear it up after the Move. Is there anything I can do to help troubleshoot this?