stringtheory / museumofglitter

This is the static website for the Museum of Glitter.
MIT License
4 stars 0 forks source link

All imagery without text should be flipped if page declared RTL #2

Open iwsfutcmd opened 6 years ago

iwsfutcmd commented 6 years ago

Presumably, the disco ball gifs are intended to rotate in a "forward" direction and the unicorn is intended to face in a "backward" direction. If the page is localized to an RTL script like Hebrew, Arabic, Phoenician, or Imperial Aramaic, the disco balls will appear to rotate "backwards" and the unicorn will appear to face "forward":

screenshot from 2018-09-12 19-58-08

This is clearly the unintended behavior.

A possible fix could be to use the :dir() pseudo-class, though it would only work in the latest versions of Firefox.

Please fix immediately.

stringtheory commented 6 years ago

Until someone steps up to write translations for a rtl language, I am holding off implementing this ticket. rtl doesnt do much good in English. And Google translating the site IS NOT A PROPER TRANSLATION - so don't just go lazy translating just to get me to do work. I have a day job, and this would take like 20 whole minutes, I could use that time browsing kitten gifs on imgur, or posting incorrect answers on stack overflow to confuse new developers & ensure my job security.

I think you can use some sort of chrome extension to just use google translations anyways. Can someone double check that assumption for me?

iwsfutcmd commented 6 years ago

screenshot from 2018-09-13 18-29-36

happy now?

ps I also noticed that in the nav bar, letter-spacing: 0.1em. as is obvious by the following picture, this breaks cursive scripts like Arabic, N'Ko, joined Adlam, Middle Persian written in the Psalter Pahlavi script, and Hanafi Rohingya — which I might add was just added to Unicode. Just imagine all those hopeful Rohingya people, finally seeing their language on a computer, excited to visit the Museum of Glitter, and discovering that the letters are slightly disconnected in the navigation bar! Congratulations, they'll never trust another "webmaster" again.

screenshot from 2018-09-13 18-32-26