stulp / dmpbbo

Python/C++ library for Dynamical Movement Primitives and Black-Box Optimization
GNU Lesser General Public License v2.1
224 stars 90 forks source link

Refactor Parameterizable in C++ #63

Closed stulp closed 2 years ago

stulp commented 2 years ago

Due to the use of the "mask", the Parameterizable implementation is complex and inefficient (the main design decision behind it was to keep the implementations in its subclasses simple; now I see it makes Parameterizable itself too complex).

It should be refactored so that:

That should make the code easier to debug. The current complexity is the bottleneck for allowing DmpWithGainSchedules to inherit from Parameterizable (see #61)

stulp commented 2 years ago

Started doing this in ba33e3808025c

stulp commented 2 years ago

This issue has been resolved by removing Parameterizable from the C++ version of dmpbbo in V2: https://github.com/stulp/dmpbbo/tree/v2