Change URL structure - Githubissues

stxnext-csr / volontulo

Web portal for collaboration of community volunteers with organizations and institutions.

MIT License

14 stars 24 forks source link

Change URL structure #361

Open radoslawroszkowiak opened 9 years ago

radoslawroszkowiak commented 9 years ago

Currently the URL pattern is /, ie. /organizations/organization-1/1

To be more logical (is '1' an attribute of organization-1 object?), more SEO friendly and more conveniently testable it would be better to have unique slugs and avoid putting ids in the url

magul commented 9 years ago

@radoslawroszkowiak the url pattern was designed that way - we assume, that there will be possibility to change name of organization, a because of that only id number is unmutable and unique identifier of organization (and title for offers and so on).

This issue for reasons mentioned above should be closed as wontfix.

radoslawroszkowiak commented 9 years ago

@magul I think this should be handled by the redirects

magul commented 9 years ago

@radoslawroszkowiak It's actually handled by redirects, but there could be a situation, where there exist multiple organizations (or offers) with that same name.

And of course right now You can put whatever You want as slug, and it will be redirected to correct one.

And because urls are part of UX we should at least ask @doslizlo .

Yog commented 9 years ago

@magul we can possibly change the concept.

new solution will require keeping history of title changes so the system can know old urls already shared somewhere
old solution doesn't need history but as @radoslawroszkowiak just mentioned privately, this is troublesome for tests.

It may be tough call but we should pick solution that will be the most optimal for development time now and especially future.

radoslawroszkowiak commented 9 years ago

@magul Of course slugs should be unique, even when their basis (i.e. name) are duplicated. Anyway, I don't want to argue about it. If you are happy about how it is, let's keep it.

magul commented 9 years ago

@Yog I understand the issue with testing, but I'm no convinced, that we should change functionality of application because of that and without even asking @doslizlo.

@radoslawroszkowiak I'm really open for disscussion but I'm not responsible for design and we really need to ask Dominik.

magul commented 9 years ago

@radoslawroszkowiak @Yog I have assigned this one to @doslizlo and it can wait for @doslizlo approval.