stxnext-csr / volontulo

Web portal for collaboration of community volunteers with organizations and institutions.
MIT License
14 stars 24 forks source link

closes #448 - deleted link in the footer, view left untouched #500

Closed KrzysztofMadejski closed 8 years ago

KrzysztofMadejski commented 8 years ago

Story / Bug id: https://github.com/stxnext-csr/volontulo/issues/CC-5790 Reference person: @yourgithubname Description:

Description of your changes.

New imports / dependencies:

Unit Tests:

What tests do I need to run to validate this change:

Description of testing workflow and potential affected places.

codecov-io commented 8 years ago

Current coverage is 91.04%

Merging #500 into master will decrease coverage by -0.03% as of 5284b94

@@            master    #500   diff @@
======================================
  Files           39      39       
  Stmts         1848    1843     -5
  Branches         0       0       
  Methods          0       0       
======================================
- Hit           1683    1678     -5
  Partial          0       0       
  Missed         165     165       

Review entire Coverage Diff as of 5284b94

Powered by Codecov. Updated on successful CI builds.

magul commented 8 years ago

The plan is, that if we are going to remove link, we need also to remove view and urls.

KrzysztofMadejski commented 8 years ago

I've cleaned the view, it's ready for merge

tomaszwozniak commented 8 years ago

looks good

magul commented 8 years ago

:+1: - merging.