stxnext-csr / volontulo

Web portal for collaboration of community volunteers with organizations and institutions.
MIT License
14 stars 24 forks source link

Issues #464 and #466 (admin panel navigation) #514

Closed Ziachu closed 8 years ago

Ziachu commented 8 years ago

Story / Bug id: #464 Story / Bud id: #465 Story / Bud id: #466 Reference person: @Ziachu Description:

New imports / dependencies:

Unit Tests:

None

What tests do I need to run to validate this change:

Description of testing workflow and potential affected places.

radoslawroszkowiak commented 8 years ago

Please sync it with current master so that there were no conflicts

tomaszwozniak commented 8 years ago

Minor comments

tomaszwozniak commented 8 years ago

0.87s$ pep8 --exclude='apps/volontulo/migrations/*,node_modules,.ropeproject' . ./apps/volontulo/views/admin_panel.py:6:1: E302 expected 2 blank lines, found 1 ./apps/volontulo/views/admin_panel.py:8:1: W191 indentation contains tabs ./apps/volontulo/views/admin_panel.py:9:1: W191 indentation contains tabs ./apps/volontulo/views/admin_panel.py:10:1: W191 indentation contains tabs ./apps/volontulo/views/admin_panel.py:11:1: W191 indentation contains tabs

tomaszwozniak commented 8 years ago

+------------------+------------+ |message id |occurrences | +==================+============+ |locally-disabled |119 | +------------------+------------+ |missing-docstring |1 | +------------------+------------+

codecov-io commented 8 years ago

Current coverage is 90.77%

Merging #514 into master will decrease coverage by -0.36% as of 23e88ad

@@            master    #514   diff @@
======================================
  Files           40      41     +1
  Stmts         1872    1875     +3
  Branches         0       0       
  Methods          0       0       
======================================
- Hit           1706    1702     -4
  Partial          0       0       
- Missed         166     173     +7

Review entire Coverage Diff as of 23e88ad

Powered by Codecov. Updated on successful CI builds.

tomaszwozniak commented 8 years ago

looks good