search

stxnext-csr / volontulo

Web portal for collaboration of community volunteers with organizations and institutions.
MIT License
14 stars 24 forks source link

Error after an attempt to create an offer #530

Closed krzysztofzuraw closed 8 years ago

krzysztofzuraw commented 8 years ago

Story / Bug id: https://github.com/stxnext-csr/volontulo/issues/461 Reference person: @krzysztofzuraw Description: Error after an attempt to create an offer New imports / dependencies:- Unit Tests:

What tests do I need to run to validate this change:-

tomaszwozniak commented 8 years ago

$ pep8 --exclude='apps/volontulo/migrations/*,node_modules,.ropeproject' . ./apps/volontulo/models.py:172:5: E303 too many blank lines (2) ./apps/volontulo/lib/email.py:62:73: W291 trailing whitespace ./apps/volontulo/tests/views/test_offers.py:219:1: W293 blank line contains whitespace ./apps/volontulo/tests/views/test_offers.py:221:5: E303 too many blank lines (2) ./apps/volontulo/views/offers.py:102:32: W291 trailing whitespace

nbbn commented 8 years ago

@krzysztofzuraw Do you try to fix #417 by "Right now user can pick date"? I work on that (#417) issue.

krzysztofzuraw commented 8 years ago

@nbbn Ok no problem I reverted my last commit. Go on!

codecov-io commented 8 years ago

Current coverage is 90.80%

Merging #530 into master will decrease coverage by -0.33% as of 05dc21d

@@            master   #530   diff @@
=====================================
  Files           40     41     +1
  Stmts         1872   1882    +10
  Branches         0      0       
  Methods          0      0       
=====================================
+ Hit           1706   1709     +3
  Partial          0      0       
- Missed         166    173     +7

Review entire Coverage Diff as of 05dc21d

Powered by Codecov. Updated on successful CI builds.

tomaszwozniak commented 8 years ago

:+1:

msobas commented 8 years ago

:+1: merge it :)