search

stxnext-csr / volontulo

Web portal for collaboration of community volunteers with organizations and institutions.
MIT License
14 stars 24 forks source link

close #468, status in offers list #535

Closed arjamizo closed 8 years ago

arjamizo commented 8 years ago

Story / Bug id: https://github.com/stxnext-csr/volontulo/issues/468 Reference person: @arjamizo Description:

Add status column in table listing all the offers, both on organisation profile and /me page.

New imports / dependencies:

Unit Tests:

What tests do I need to run to validate this change:

python manage.py test apps.volontulo.tests.views.test_organizations --settings=volontulo_org.settings.dev 

test__ensure_status_is_displayedin_profile_view, 
test__ensure_status_is_displayedin_organisations_view
codecov-io commented 8 years ago

Current coverage is 91.45%

Merging #535 into master will increase coverage by +0.49% as of 880628c

@@            master    #535   diff @@
======================================
  Files           41      53    +12
  Stmts         1948    2060   +112
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           1772    1884   +112
  Partial          0       0       
  Missed         176     176

Review entire Coverage Diff as of 880628c

Powered by Codecov. Updated on successful CI builds.

msobas commented 8 years ago

pep8 is fine just preferences comment :) u'' is in almost any PR, so I guess we can leave it for now. :+1:

arjamizo commented 8 years ago

So is this going to be merged into origin?

magul commented 8 years ago

@arjamizo I have just merged it, but we have stuck in others projects so there will be for a while no so much activity here.