search

stxnext-csr / volontulo

Web portal for collaboration of community volunteers with organizations and institutions.
MIT License
14 stars 24 forks source link

475 user photo me #537

Closed radoslawroszkowiak closed 8 years ago

radoslawroszkowiak commented 8 years ago

Story / Bug id: https://github.com/stxnext-csr/volontulo/issues/475 Reference person: @radoslawroszkowiak Description:

Description of your changes.

New imports / dependencies: *mock

codecov-io commented 8 years ago

Current coverage is 91.20%

Merging #537 into master will increase coverage by +0.43% as of 230eab0

@@            master   #537   diff @@
=====================================
  Files           41     41       
  Stmts         1875   1887    +12
  Branches         0      0       
  Methods          0      0       
=====================================
+ Hit           1702   1721    +19
  Partial          0      0       
+ Missed         173    166     -7

Review entire Coverage Diff as of 230eab0

Powered by Codecov. Updated on successful CI builds.

filipgorczynski commented 8 years ago

Like @radoslawroszkowiak said there is a potential in refactoring but there is no time for this, at least for now. I think it could go in this form. :+1:

Yog commented 8 years ago

Why didn't you merge it? I think it wasn't that bad, or was it? ;D

magul commented 8 years ago

@Yog I know, that @radoslawroszkowiak have closed this PR. I have pulled his changes and will prepare new PR.