sultim-t / xash-rt

Fork of the Xash3D FWGS with a real-time path tracing
1.08k stars 25 forks source link

Exit signs have no emission #169

Open AlpyneDreams opened 1 year ago

AlpyneDreams commented 1 year ago

The exit sign on the tram does not emit light. It is very noticeable. It is also an OSHA violation 😏

Base Profile Screenshot 2023 03 21 - 22 32 15 42

Compare with classic lighting: Base Profile Screenshot 2023 03 21 - 22 36 03 00

Suggested Fix

It can be fixed by adding the following to textures.json: (or something similar)

// exit signs
,{"textureName":"#maps/exit1.mip"         ,"emissiveMult":0.1,"lightIntensity":10,"lightColor":[255, 0, 0], "lightEvenOnDynamic": true}
,{"textureName":"#maps/exitlft.mip"         ,"emissiveMult":0.1,"lightIntensity":10,"lightColor":[248, 0, 0], "lightEvenOnDynamic": true}
,{"textureName":"#maps/exitrt.mip"         ,"emissiveMult":0.1,"lightIntensity":10,"lightColor":[255, 0, 0], "lightEvenOnDynamic": true}

My fix: Base Profile Screenshot 2023 03 21 - 22 36 17 67

This may need to be tweaked slightly per-map. In c1a0 it's actually supposed to flash on and off (it does in the full game), but classic mode shows it as being off.

Yes, it is a moving object, so it needs lightEvenOnDynamic. Since the player is inside the tram, it doesn't move relative to the player view, and the light is very tiny, the light source moving does not create any more noise than the existing lights in the tram do, even on lowest FSR, in my experience - so this should be fine.