sultim-t / xash-rt

Fork of the Xash3D FWGS with a real-time path tracing
1.08k stars 25 forks source link

Green Glow/Red Shadow Bug #191

Open outlawedruffian opened 1 year ago

outlawedruffian commented 1 year ago

Mentioned previously by a different user in Discussions, but no current fix it seems. There's a green glow around some lights and a red hue around some shadows. Screenshot 2023-05-01 172023

brurpo commented 1 year ago

Same problem here tried running with console enabled to see if there are any hints, but couldnt figure it out image

TuTuc0 commented 1 year ago

I have the same issue recently, maybe nvidia driver update caused this?

GreenGroove46 commented 1 year ago

This is maybe studio driver, try to install game ready driver.

TuTuc0 commented 1 year ago

It is game ready driver. Update: When I installed 531.79 driver, the issue was fixed. But installing 535.98 driver released recently, brings back the issue.

GreenGroove46 commented 1 year ago

Im stayng on 521 driver lol.

PinkPanther901 commented 1 year ago

Also experiencing the same on a 3070TI with driver version 535.98

Edit: Downgrading to 531.68 has solved this issue

KrDimitrov commented 1 year ago

Setting rt_emis_mapboost to 0 in the console seems to somewhat fix this issue, im not sure if it affects anything else though

pedricaro10 commented 1 year ago

Setting rt_emis_mapboost to 0 in the console seems to somewhat fix this issue, im not sure if it affects anything else though

thanks man work

ianalexis commented 1 year ago

Setting rt_emis_mapboost to 0 in the console seems to somewhat fix this issue, im not sure if it affects anything else though

It works for me but what's the default value? there is a new NVIDIA driver and i want to check it but but it seems that the new 0 value stays.

KrDimitrov commented 1 year ago

It works for me but what's the default value? there is a new NVIDIA driver and i want to check it but but it seems that the new 0 value stays.

It seems like the default value is 100.

Setting it to 0 removes the green glow but the red shadows remain

Just tried it with the new driver but its still broken

ianalexis commented 1 year ago

I didn't noticed the reddish shadows until you say it, i though that it was an "artistic" decision specially present at the rocky mountains part at the beginning. Is not as red with older drivers (still too much IMHO). Is it still present after the Black mesa metro system? Maybe is something in the skybox? IDK. Tried a los of changes with this values but nothing helps. https://github.com/a1batross/xash-rt/blob/615616b4f87dbeaa47ec0846b8f5bd76ad87327c/ref/gl/gl_opengl.c#L942

Maybe it is a NVIDIA specific problem.

DudeDudeson9 commented 1 year ago

Also seeing the green glow bug with new Nvidia game driver 536.23.

20230614171332_1

Blok88 commented 1 year ago

Driver 535.98 Base Profile Screenshot 2023 06 16 - 01 44 18 57

RsVBiiker commented 1 year ago

same needs fixing looks like the denoiser values have changed in the driver

NyTR0S96 commented 1 year ago

so your telling me the current fix right now it so downgrade my driver? thats annoying. i dont wanna do that just for 1 game. lmk when this gets fixed.

sultim-t commented 1 year ago

Uggghhhh.. okay, I don't know how but hopefully it's fixed now.

I would speculate that there were some internal changes to a compiler that broke the code. I really would to know why moving variables around solves the issue with green component of emissive surfaces being extremely large

hl1-rt-latestdriversfix.zip

KrDimitrov commented 1 year ago

Seems like the green glow is fixed, but the red shadow is unfortunately still there.

image vs image

Gibshooter commented 1 year ago

Uggghhhh.. okay, I don't know how but hopefully it's fixed now.

I would speculate that there were some internal changes to a compiler that broke the code. I really would to know why moving variables around solves the issue with green component of emissive surfaces being extremely large

hl1-rt-latestdriversfix.zip

It fixed the green render bug for me. The game is now definitely playable and looking good.

As Dimitrov stated, there's still that red tone in the darker regions. The intro canyon scene has a strong post apocalyptic character due to this. But this is nothing compared to the green lights.

sultim-t commented 1 year ago

Oof, yeah, I will try to look at it tomorrow

Githubdog1 commented 1 year ago

Oof, yeah, I will try to look at it tomorrow

Thank you Sultim, we would really appreciate it, if you could this all fixed.

b0nesy commented 1 year ago

just chiming in to confirm setting rt_emis_mapboost to 0 fixed the green rays, but not the red shadows. love this project, happy to wait for a fix. hope another comment confirming these tweaks helps :)

sultim-t commented 1 year ago

Another strange fix...

For some reason, just a presence of a conditional in the GI shader makes everything more red: no matter what it evaluates to (the branch was exectuted even if conditional is false (i.e. cvar rt_indir2bounces is 0)). And commenting that statement completely just works for some reason, might be an alignment, but other shader vars work fine it seems... another mystery.

hl1-rt-latestdriversfix2.zip

Githubdog1 commented 1 year ago

Another strange fix...

For some reason, just a presence of a conditional in the GI shader makes everything more red: no matter what it evaluates to (the branch was exectuted even if conditional is false (i.e. cvar rt_indir2bounces is 0)). And commenting that statement completely just works for some reason, might be an alignment, but other shader vars work fine it seems... another mystery.

hl1-rt-latestdriversfix2.zip

Sooooo, does this mean that the red glow is also fixed??

raphcool12 commented 1 year ago

yeah work for me now thanks alot sir