sultim-t / xash-rt

Fork of the Xash3D FWGS with a real-time path tracing
1.09k stars 23 forks source link

Weird artefact with DLSS #93

Open wenceslaorl opened 1 year ago

wenceslaorl commented 1 year ago

Weird artefact with DLSS 2.5.1

Rtx 3070 Windows 10 asd

olavaketun commented 1 year ago

This is present in both DLSS and FSR sadly, I think it's the denoiser smudging and blending fireflies so an underlying problem of the rendering. I'm not sure if it can be fixed easily, but other engines have mitigated fireflies by clamping the rays values within acceptable bounds. Unity does this with their raytracing and pathtracing.

sultim-t commented 1 year ago

The fireflies are being clamped by looking into the neighborhood pixels, but here multiple fireflies are in the pixel region, so clamping fails... I need to look into the sampling, might be some inconsistency

osiris-plus commented 1 year ago

Fireflies seem to appear more often on high FPS.