search

sunaku / wmiirc

Ruby configuration for WMII window manager
ISC License
82 stars 26 forks source link

wmii dies due to dead links in $PATH #40

Closed 0x64746b closed 12 years ago

0x64746b commented 12 years ago

I assume 6018bff57fed60742417caab1b12227736996fbe introduces a problem that causes wmii to die when there are dead links in the $PATH. That sucks. The window manager shouldn't depend on a cleaned up path.

In addition, the error message is misleading and might make the user believe he's missing a dependency ('dependencies' on javaws and pluginappletviewer really got my blood boilin' -.-)

#<Errno::ENOENT: No such file or directory - /usr/bin/javaws>
/home/dtk/.wmii-hg/control/action/launch.yaml:control:action:launch_menu_rehash:3:in `stat'
/home/dtk/.wmii-hg/control/action/launch.yaml:control:action:launch_menu_rehash:3:in `block (5 levels) in control'
/home/dtk/.wmii-hg/control/action/launch.yaml:control:action:launch_menu_rehash:2:in `select'
/home/dtk/.wmii-hg/control/action/launch.yaml:control:action:launch_menu_rehash:2:in `block (4 levels) in control'
/home/dtk/.wmii-hg/control/action/launch.yaml:control:action:launch_menu_rehash:1:in `map'
/home/dtk/.wmii-hg/control/action/launch.yaml:control:action:launch_menu_rehash:1:in `block (3 levels) in control'
/home/dtk/.wmii-hg/lib/wmiirc/handler.rb:20:in `call'
/home/dtk/.wmii-hg/lib/wmiirc/handler.rb:20:in `block in handle'
/home/dtk/.wmii-hg/lib/wmiirc/handler.rb:19:in `each'
/home/dtk/.wmii-hg/lib/wmiirc/handler.rb:19:in `handle'
/home/dtk/.wmii-hg/lib/wmiirc/handler.rb:61:in `action'
/home/dtk/.wmii-hg/control/action/launch.yaml:script:after:1:in `block in script'
/home/dtk/.wmii-hg/lib/wmiirc/config.rb:38:in `instance_eval'
/home/dtk/.wmii-hg/lib/wmiirc/config.rb:38:in `block in script'
/home/dtk/.wmii-hg/lib/wmiirc/config.rb:37:in `each'
/home/dtk/.wmii-hg/lib/wmiirc/config.rb:37:in `script'
/home/dtk/.wmii-hg/lib/wmiirc/config.rb:17:in `apply'
/home/dtk/.wmii-hg/lib/wmiirc/loader.rb:118:in `load_user_config'
/home/dtk/.wmii-hg/lib/wmiirc/loader.rb:23:in `run'
/home/dtk/.wmii-hg/wmiirc:5:in `<main>'

I don't know what the responsible patch is doin', but it would be great if he wouldn't crash WMII.

sunaku commented 12 years ago

That's really strange. We're looping on the result of Dir.entries so those files should exist. Anyway see if d30f1e3d7d6465faa1b5103ad64c6046ae1976e9 fixes the problem.

0x64746b commented 12 years ago

yepp, you fixed it. thx.