sunrisemvmtnyc / legislation-tracker

Easy, intuitive legislation tracker made by the Sunrise Digital Tools team
0 stars 1 forks source link

Feature/filter by category #40

Closed derekmiranda closed 4 months ago

derekmiranda commented 5 months ago

addresses https://github.com/sunrisemvmtnyc/legislation-tracker/issues/39

Filters bills by category on backend

Currently, no bills in the first 100 are in the categories so added a temp entry ('A2229' w/ 'renews' category)

agreffard commented 4 months ago

Sorry I took long to read the PR and respond.

From what I remember, we said we would only display the Sunrise featured bills ayway, right? If that's the case, maybe we could be more specific with the elastic search to directly fetch only the list of bills we want (coming from the Airtable) :

https://legislation.nysenate.gov/api/3/bills/2023/search?term=printNo:(S3545 OR S4024 OR ...)&key=[API KEY]

it means we could also get rid of the pagination/limit issues

We can talk about it tomorrow! @derekmiranda @elliott-king @twblackwell @afnanhaq (We had multiple debates about it so I'm not sure about the last thing we said, I might be wrong)

derekmiranda commented 4 months ago

The other PR seems blocked on this. Let's just merge it, and I'll make a new PR if necessary, instead of delaying you.

@elliott-king just need you to re-approve this PR since i made a change after you approved. feel free to merge it as well