chore: "Advanced page" design improvements

sunrisemvmtnyc / legislation-tracker

Easy, intuitive legislation tracker made by the Sunrise Digital Tools team

0 stars 1 forks source link

chore: "Advanced page" design improvements #60

Closed elliott-king closed 3 weeks ago

elliott-king commented 3 months ago

To test:

Visit "advanced page". Verify you can see table. Should be scrollable and filterable by bills & legislators. Should show legislator bill percentage on left.

Some MVP needed improvements to make the page usable:

[x] column header - use printno & show title on hover
[x] horizontal axis text box filter bill
[x] vert axis text box filter legislator
[x] css improvements: clearer divisions
[x] show column header even while scrolled
[x] show leg name even while scrolled
[x] campaign super-header
[x] all leg pct & climate leg pct

agreffard commented 1 month ago

@elliott-king When I open the advanced page I have a lot of errors like this and the app crashes:

TypeError: billCampaignMappings[bill.basePrintNo] is not iterable

And when I fix the frontend to handle these cases with default values it seems like I have incomplete data:

I dont see any network/requests error though. Am I missing something (some setup steps?) to have it running locally?

elliott-king commented 1 month ago

@agreffard looking into this, may ask to chat with you next week

elliott-king commented 1 month ago

@agreffard can we chat before/after the next meeting?

agreffard commented 1 month ago

@elliott-king Sure! I can chat tonight (Monday) or after Wednesday's meeting

elliott-king commented 3 weeks ago

@agreffard made the changes, merging.