aldebout commented 3 months ago

Bug report

[x] I confirm this is a bug with Supabase, not with my own application.
[x] I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

When using @supabase/supabase-js in an expo react native project, if I use the unstable_enablePackageExports with the metro bundler, bundling fails with the following error:

To Reproduce

Generate a new expo app
Add @supabase/supabase-js as a dependency
Create a supabase client in the main _layout.tsx file
Run npx expo customize metro.config.js
Add config.resolver.unstable_enablePackageExports = true; to metro.config.js
Add ios.bundleIdentifier to app.json
Run npx expo run:ios

Repro repo: https://github.com/aldebout/supabase-expo-exports-issue

Expected behavior

No crash

Screenshots

System information

OS: macOS
Version of supabase-js: 2.45.1
Version of Node.js: 20.16.0

Additional information

Opening here because the error message I got in my actual project was

The package at "../../node_modules/@supabase/realtime-js/node_modules/ws/lib/stream.js" attempted to import the Node standard library module "stream".
It failed because the native React runtime does not include the Node standard library.

practiv-wamci commented 2 months ago

Is there any update on this? I've run into the same issue

filipecabaco commented 2 months ago

now that we have native ws support I do think that we can remove ws which seems to be the source of the issue.

https://github.com/supabase/realtime-js/pull/426 here's a branch for us to use for testing to see if we can fix it by removing ws from realtime-js dependencies.

but after removing it I keep getting the same issue and the only dependency that uses it's node_modules/@expo/cli 😞 . what could be the way to fix it?

aldebout commented 1 month ago

@filipecabaco I'm not sure what the next step is, how can I help you?

filipecabaco commented 1 month ago

@aldebout maybe. it seems that the main issue was the fact that we had the ws dependency which created issues with expo. the PR https://github.com/supabase/realtime-js/pull/426 removes said dependency.

could you try to checkout the repo, checkout the branch fix/remove-ws-lib and override the dependency to check if it's not something related to my environment?

aldebout commented 1 month ago

I tried using the branch but I'm having issues because package.json references the build outputs (/dist/...) and they're not in the github source code :/ When you tested locally, did you use npm with overrides or a local link? I've had issues with npm overrides in the past, it might work better with yarn or pnpm.