supabase / realtime-js

An isomorphic Javascript client for Supabase Realtime server.
https://supabase.com
MIT License
320 stars 58 forks source link

this.setupConnection() is not called for a custom transport #433

Open lauri865 opened 1 week ago

lauri865 commented 1 week ago

Bug report

Describe the bug

Bringing this to the attention, as it will likely disappear in the void otherwise: https://github.com/orgs/supabase/discussions/30361

How can one implement a custom transport when setupConnection is not run against it from the RealtimeClient?

lauri865 commented 1 week ago

We have patched realtime-js on our end and added the missing setupConnection line. Everything seems to be working well.

I presume it's just an oversight/bug, because otherwise one would have to reimplement the whole realtmeclient in order to use a custom transport.