search

superbob / clicker-heroes-1.0-hsoptimizer

Clicker Heroes 1.0 HS Optimizer
https://superbob.github.io/clicker-heroes-1.0-hsoptimizer
5 stars 1 forks source link

Added support for Nogardnit #21

Closed formicas closed 7 years ago

formicas commented 7 years ago

Hi superbob, I haven't added tests for this yet, I just wanted to say hi and thanks for the calculator. I've had a quick crack at adding nogardnit support and it seems to work OK, but this is more of a request for feedback than a full-on pull request!

Cheers, formcias

superbob commented 7 years ago

Hi, thanks for the contribution. It will help #20. I won't necessarily require contributors to write new tests. But I'd like old tests to still pass. I haven't ran current tests against your commit but I suppose some of them will fail. To be sure of that, I'm adding automated tests with travis-ci.

formicas commented 7 years ago

Actually the current tests all still pass because none of them contain nogardnit so it doesn't include it in suggestions.

superbob commented 7 years ago

Okay, I see. Honestly I just looked at changed files and it seemed OK to me.

I'll dig into this a little deeper to see how to integrate it best with existing tests and the entire codebase.

For the information, in the meantime I've finished travis integration so future PR will be verified automatically.