superbox-dev / unipi-control

Control Unipi I/O directly with MQTT commands.
Apache License 2.0
7 stars 3 forks source link

Support authentication for MQTT #118

Closed kepi closed 9 months ago

kepi commented 9 months ago

I don't have any MQTT instance without authentication in place, so it would be better to test this before merging.

IMHO it should work fine, as both username and password should be None by default, which seems right approach to use with Client from aiomqtt.

mh-superbox commented 9 months ago

Thank you for this improvement. The changes look good to me. I just realized that these changes belong to the 4% (96% coverage) untested code :-D

Can you please update the CHANGELOG.md.

kepi commented 9 months ago

Sure, changelog updated.