search

superbox-dev / unipi-control

Control Unipi I/O directly with MQTT commands.
Apache License 2.0
7 stars 3 forks source link

Support for Unipi Axon L205 #120

Closed kepi closed 9 months ago

mh-superbox commented 9 months ago

Nice to see that a Unipi Axon is also recognized correctly. It looks like it is recognized as a neuron. Somewhere here: https://github.com/superbox-dev/unipi-control/blob/856d0121d3f4bf4d3d8c38343f961119861786ab/unipi_control/config.py#L535

I'm not sure yet if the /neuron/ folder is suitable for an Axon configuration file, but for now I would leave it as it is.

kepi commented 9 months ago

I'm not sure yet if the /neuron/ folder is suitable for an Axon configuration file, but for now I would leave it as it is.

Yeah, I thought about it for about a second :) but then realized, that you already have all kinds of devices inside that directory. Neuron devices all end with 3, Axon with 5 and Patron with 7. IMHO it might be easier to simply rename directory to unipi than splitting into per-product-line directories.

mh-superbox commented 9 months ago

Neuron devices all end with 3, Axon with 5 and Patron with 7. IMHO it might be easier to simply rename directory to unipi than splitting into per-product-line directories.

I didn't know that :)

"plc" (programmable logic controller) would be a suitable name for the directory, then we would have "extensions" and "plc".

I am still waiting with this change, because it is a breaking change and I have to add a "deprecated" warning for the old path.