supertestnet / superstore

A simple bitcoin webstore with whisper addresses for enhanced privacy
https://supertestnet.github.io/superstore/
Creative Commons Zero v1.0 Universal
97 stars 27 forks source link

Multiple questions/thoughts about project #10

Open lpoirothattermann opened 1 year ago

lpoirothattermann commented 1 year ago

Hello,

I really like the idea, but when I read source code I got some questions.

Do you have some opinions ?

supertestnet commented 1 year ago

Hi Ipoiro, thank you for your questions!

Why you don't use framework like Vue.js/React.js/Angular... ?

I don't really like or understand frameworks. They seem very complicated and the way they "want" you to do things doesn't match the way I "enjoy" doing things. So I avoid them.

It would be great to create Onion address as proxy to Github page

It would be pretty easy to host an onion service for magic webstore. Feel free to spin one up!

It would be great to use "private" hosted sources for packages

I don't know what you mean by private hosted sources for packages. Can you give an example? I often use cdns, e.g. most of the library dependencies are taken from bundle.run, which is a cdn.

It also to be great to use css library

Why? The css is not very complicated so it's easy to do it by hand, and doing so removes another dependency on yet another library. I like to avoid libraries whenever possible.

cleaner/better UI

I agree, I would love it if it had a better UI. Feel free to do a pull request and I'll review and maybe merge it.

faster development

I don't know how to develop faster. Are you concerned that I am too slow with updates?

lpoirothattermann commented 1 year ago

o/,

Why you don't use framework like Vue.js/React.js/Angular... ?

I don't really like or understand frameworks. They seem very complicated and the way they "want" you to do things doesn't match the way I "enjoy" doing things. So I avoid them. Yes I got you, but would be easier for newcomer, maybe just start to organize code in folders (views, utils, service ...) would be a very good start :)

It would be great to create Onion address as proxy to Github page

It would be pretty easy to host an onion service for magic webstore. Feel free to spin one up! I don't have a server free and ready to use, maybe if the project is appreciated by the community you can create a monero or/and bitcoin tip address.

It would be great to use "private" hosted sources for packages

I don't know what you mean by private hosted sources for packages. Can you give an example? I often use cdns, e.g. most of the library dependencies are taken from bundle.run, which is a cdn. Atm you libraries relies on other sources than yours (bitcoincore.tech, bundle.run) it would be nice to host everything on supertestnet.github.io like qrcode.js.

<script src="https://bitcoincore.tech/apps/bitcoinjs-ui/lib/bitcoinjs-lib.js"></script>
<script src="https://supertestnet.github.io/bitcoin-chess/js/qrcode.js"></script>
<script src="https://bundle.run/noble-secp256k1@1.2.14"></script>
<script src="https://bundle.run/browserify-cipher@1.0.1"></script>
<script src="https://bundle.run/bech32@2.0.0"></script>
<script src="https://bundle.run/buffer@6.0.3"></script>

It also to be great to use css library

Why? The css is not very complicated so it's easy to do it by hand, and doing so removes another dependency on yet another library. I like to avoid libraries whenever possible. Once again, I get you. But libraries are very efficient, you pick on css library, config it. That will prevent contributor to do different style. (and the majority of people don't really want to deal with css... better for newcomers)

cleaner/better UI

I agree, I would love it if it had a better UI. Feel free to do a pull request and I'll review and maybe merge it. I'm really not your guy with design...

faster development

I don't know how to develop faster. Are you concerned that I am too slow with updates? Nooo I don't say that your are slow, I just tell that with right stack you could ship faster, make the project more maintainable and easier for newcomer to onboard.

supertestnet commented 1 year ago

would be easier for newcomer

I guess it depends on the kind of newcomer. If the newcomer is familiar with vuejs I'm sure it would help them if this was written in vue. But what if they are only familiar with vanilla js and not with any frameworks? For that newcomer (who I closely identify with), vanilla js is perhaps the easiest thing to deal with

maybe if the project is appreciated by the community you can create a monero or/and bitcoin tip address

Yeah I agree

you libraries relies on other sources than yours

Yeah that is an easy change, I will add that to my to do list

libraries are very efficient

Not in my experience. I personally find that libraries slow my pages down because they tend to import a bunch of code that I don't use. The loading time for that unused code annoys me.

the majority of people don't really want to deal with css... better for newcomers

I don't think newcomers want to deal with css libraries either

with right stack you could ship faster

I think I found the right stack, it's the one I'm using :) thank you!