bannerConfig should not default if not filled, it should be left out - Githubissues

swashata / wp-webpack-script

💥🔥📦👩‍💻 An easy to use, pre configured, hackable webpack setup & development server for WordPress themes and plugins.

https://wpack.io

MIT License

407 stars 57 forks source link

bannerConfig should not default if not filled, it should be left out #1250

Open chrion02 opened 2 years ago

chrion02 commented 2 years ago

The default bannerConfig should be left out in: https://github.com/swashata/wp-webpack-script/blob/77d9189fcac726e3adcd6129dd6079badc7486fc/packages/scripts/src/config/project.config.default.ts#L115-L130

Inlining css chunks is not pretty with a bannerConfig for each file. There is no need for a default config. Even bannerConfig: false does just return undefined for every property in: https://github.com/swashata/wp-webpack-script/blob/8d6be7522cbb1164d1446709e9c0c7cdd8b289fe/packages/scripts/src/config/WebpackConfigHelper.ts#L380-L402