swri-robotics / bag-database

A server that catalogs bag files and provides a web-based UI for accessing them.
Other
342 stars 71 forks source link

Bump h2 from 1.4.195 to 2.1.210 #171

Open dependabot[bot] opened 2 years ago

dependabot[bot] commented 2 years ago

Bumps h2 from 1.4.195 to 2.1.210.

Release notes

Sourced from h2's releases.

Version 2.1.210

Two security vulnerabilities in H2 Console (CVE-2022-23221 and possible DNS rebinding attack) are fixed.

Persistent databases created by H2 2.0.x don't need to be upgraded. Persistent databases created by H2 1.4.200 and older versions require export into SQL script with that old version and creation of a new database with the new version and execution of this script in it.

... (truncated)

Commits
  • ca926f8 Merge remote-tracking branch 'h2database/master'
  • be306de Version advancement
  • 030eb72 Improve migration documentation
  • 86d58c4 Merge pull request #3381 from katzyn/legacy
  • b613598 Typo
  • d6e4eb8 Add IDENTITY() and SCOPE_IDENTITY() to LEGACY mode
  • 36e790d make javadoc happier
  • 1c0ca27 Add "of this server" to adminWebExternalNames text
  • 0f83f48 Convert host names to lower case
  • c5f11a5 Merge pull request #3378 from katzyn/lob
  • Additional commits viewable in compare view


Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/swri-robotics/bag-database/network/alerts).

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

pjreed commented 2 years ago

Following up on #169, I just thought I'd leave a comment here that this still isn't quite ready. H2GIS has released a new version of their library that is compatible with H2 2.x, but Hibernate 5.x does not support H2, and Hibernate 6 is still in alpha/beta testing. Based purely on past experience, I also suspect upgrading from Hibernate 5 to 6 will require some more significant work, they like to break things between major releases.

danthony06 commented 2 years ago

Ouch. I notice dependabot mentioned upgrading the database with an SQL script. I assume that we'd have to write that script?

pjreed commented 2 years ago

The good news is that only applies to persistent databases; since the Bag DB only uses H2 to create transient, in-memory databases for unit testing, that doesn't apply to us.

danthony06 commented 2 years ago

@pjreed Looking at this again. From the thread you linked, can we do this?

You can add ;MODE=LEGACY to JDBC URL of H2 (you need H2 2.0.204 or later version).

and then merge in this update?

dependabot[bot] commented 1 year ago

A newer version of com.h2database:h2 exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.