search

swri-robotics / bag-database

A server that catalogs bag files and provides a web-based UI for accessing them.
Other
342 stars 71 forks source link

change listObject to iterator and stream-supplier #194

Closed lenaherrmann-dfki closed 2 years ago

lenaherrmann-dfki commented 2 years ago

In order to fetch more than 2000 bags from an s3-storage, the method list object is changed to ListObjectsV2Iterable. Further this Method now return as Stream-Supplier and pre-filters the result to .bags-only. (https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/pagination.html) Finally a minor bug was fixed for fetching the TreeNode.

pjreed commented 2 years ago

This looks good to me, thanks! (@danthony06)

danthony06 commented 2 years ago

Looks good to me as well. I just merged in the changes from the repo head that weren't in this PR, and then I'll merge it after the checks complete.