search

swsnu / swpp2021-team7

https://vidol.pinoff.io
2 stars 2 forks source link

Video clipping view updated #50

Closed YCyoon1994 closed 2 years ago

YCyoon1994 commented 2 years ago
sonarcloud[bot] commented 2 years ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 22 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

iks15174 commented 2 years ago

activeIdol(e,data){ console.log(e,data); console.log(this); if(e.target.classList.contains("is-active")){ e.target.classList.remove("is-active"); }else{ e.target.classList.add("is-active"); } } 대신에 activeIdol = (e,data) => {} 이런식으로 정의하면 this를 bind 해줄 필요가 없기 때문에 코드 길이를 좀 더 줄일 수 있을거 같습니다!

YCyoon1994 commented 2 years ago

코드 업데이트 진행하겠습니다 :)