search

swushi / react-native-input-outline

MIT License
123 stars 15 forks source link

Thin line behind placeholder #18

Open SrBrahma opened 2 years ago

SrBrahma commented 2 years ago

Hi! Just installed this lib and I am having this issue:

image

I am not passing any prop besides the placeholder, so I don't know what may be causing it. (in the image there is the char counter but later I removed it and the issue persists)

Also, is there a way to center the text and paddingLeft it a little? Tried paddingLeft but it does nothing.

image

"react-native-input-outline": "^1.5.2", "react-native-reanimated": "^2.2.2", "expo": "~42.0.4",

SrBrahma commented 2 years ago

Playing with your code,

https://github.com/swushi/react-native-input-outline/blob/8bd774d8bb1bfc11d15b17fbf96135da91019bf4/src/components/InputOutline.tsx#L378-L384

I changed this height: 1 to 2, and the line is gone.

My PixelRatio.get() is 2.75. Maybe your animation positioning with just this 1 in the style isn't enough for my device dp.

I could PR this, but I ain't quite sure this would be the best solution.

ydv0121 commented 2 years ago

+1