search

swushi / react-native-input-outline

MIT License
123 stars 15 forks source link

Size of placeholder text and assistive text should be configurable #2

Closed braincore closed 3 years ago

braincore commented 3 years ago

The default sizes appear too small to me which is why it's an immediate issue, but regardless, the sizes should be configurable for interfaces that offer adjustable text sizes.

swushi commented 3 years ago

fixed with #4

braincore commented 3 years ago

Thanks for the changes! How about making the label's size (placeholder when in top-left corner) also configurable?

On a design note, I have a suggestion (don't feel any pressure to incorporate it). You now have identical configurability for font, error, assistive, characterCount, and maybe label. But in all likelihood, error, assistive, characterCount, and label will have matching font size and family. Perhaps having only two categories (placeholder vs. everything else) of font configuration would be simpler.