sylvanaar / prat-3-0

Prat-3.0 is a chat enhancement addon for world of warcraft
https://www.curseforge.com/wow/addons/prat-3-0
GNU General Public License v3.0
25 stars 45 forks source link

TBC: Replace PARTY_MEMBERS_CHANGED with GROUP_ROSTER_UPDATE in PlayerNames.lua #226

Open mburger-scheidlin opened 3 years ago

mburger-scheidlin commented 3 years ago

I got the following error. Changing "PARTY_MEMBERS_CHANGED" to "GROUP_ROSTER_UPDATE" in PlayerNames.lua:1132 fixed this. The reference to attune is misleading at first, I think this is just because it loaded AceEvent first. See https://wowpedia.fandom.com/wiki/PARTY_MEMBERS_CHANGED

Message: ...ace\AddOns\Attune\Libs\AceEvent-3.0\AceEvent-3.0.lua:33: Attempt to register unknown event "PARTY_MEMBERS_CHANGED" Count: 1 Stack: ...ace\AddOns\Attune\Libs\AceEvent-3.0\AceEvent-3.0.lua:33: Attempt to register unknown event "PARTY_MEMBERS_CHANGED"

string "=[C]": in function RegisterEvent' [string "@Interface\AddOns\Attune\Libs\AceEvent-3.0\AceEvent-3.0.lua"]:33: in functionOnUsed' [string "@Interface\AddOns\Atlas\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:142: in function RegisterEvent' **[string "@Interface\AddOns\Prat-3.0\modules\PlayerNames.lua"]:1132: in functionOnModuleEnable'** [string "@Interface\AddOns\Prat-3.0\addon\modules.lua"]:189: in function <Interface\AddOns\Prat-3.0\addon\modules.lua:178>

[string "@Interface\AddOns\Atlas\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:70: in function <...face\AddOns\Atlas\Libs\AceAddon-3.0\AceAddon-3.0.lua:65> [string "@Interface\AddOns\Atlas\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:527: in function EnableAddon' [string "@Interface\AddOns\Atlas\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:540: in functionEnableAddon' [string "@Interface\AddOns\Atlas\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:630: in function <...face\AddOns\Atlas\Libs\AceAddon-3.0\AceAddon-3.0.lua:615>

Locals:

Road-block commented 3 years ago

Pull request #220 and test packages provided at the last comment have this (and a bunch of other stuff) fixed.

meflakcannon commented 3 years ago

This has been fixed a few times in several branches (Check branches). However due to the passing of Sylvanaar. The merges won't be approved to the main files.