Fix hash function (use 2 arg form)

symengine / SymEngine.jl

Julia wrappers of SymEngine

MIT License

192 stars 43 forks source link

Fix hash function (use 2 arg form) #187

Closed saschatimme closed 4 years ago

saschatimme commented 4 years ago

The documentation advises to implement the two argument form of Base.hash. Otherwise it can still happen that hashing happens based on the object id (which we don't want to happen).

saschatimme commented 4 years ago

@isuruf Do you have any feedback on that?

isuruf commented 4 years ago

Thanks @saschatimme. Sorry it took long to review.