Make conj interface more flexible

symengine / SymEngine.jl

Julia wrappers of SymEngine

MIT License

192 stars 43 forks source link

Make conj interface more flexible #267

Closed GiggleLiu closed 11 months ago

GiggleLiu commented 11 months ago

I need to extend the conj function for the quantum simulator Yao. However, the original interface is not allowed to overwrite.

GiggleLiu commented 11 months ago

The failed tests is not relevant, which is related to some change in SymbolicUtils.

 30 dependencies successfully precompiled in 25 seconds. 43 already precompiled.
  1 dependency had warnings during precompilation:
┌ SymEngineSymbolicUtilsExt [9cfbb343-ecf1-584a-98a6-9923b893d35f]
│  WARNING: could not import SymbolicUtils.cmp_mul_adds into SymEngineSymbolicUtilsExt
│  WARNING: could not import SymbolicUtils.cmp_term_term into SymEngineSymbolicUtilsExt
└

GiggleLiu commented 11 months ago

Hi, is it possible to get this PR merged and tag a new version? Otherwise, the following PR in Yao will be block by this PR: https://github.com/QuantumBFS/Yao.jl/pull/479

isuruf commented 11 months ago

Yes, working on it