search

symmetryinvestments / imap-d

D library for IMAP (JMAP is a work-in-progress but the basics work)
14 stars 10 forks source link

Github actions #102

Closed maxhaton closed 2 years ago

maxhaton commented 2 years ago

First go. My luck suggests something will fail but I was able to run it locally. CodeCov thing apparently will just work, someone will need to fiddle with the key if not.

codecov[bot] commented 2 years ago

Codecov Report

Merging #102 (76385ba) into master (dc5b637) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 76385ba differs from pull request most recent head 8e6d6c8. Consider uploading reports for the commit 8e6d6c8 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   17.48%   17.48%           
=======================================
  Files          10       10           
  Lines        1218     1218           
=======================================
  Hits          213      213           
  Misses       1005     1005

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dc5b637...8e6d6c8. Read the comment docs.

maxhaton commented 2 years ago

@skoppe

skoppe commented 2 years ago

Looks good, but needs to be .yml. Can also delete the travis CI file.

maxhaton commented 2 years ago

Looks good, but needs to be .yml. Can also delete the travis CI file.

That would explain why it didn't pick it up. I used act to check it ran locally and that does look for .yaml

skoppe commented 2 years ago

Hmm, it still doesn't run. Maybe my suspicion around .yml/.yaml was wrong.

Perhaps it doesn't work because you added a workflow as an external contributer and github blocks running actions in that case to prevent you installing cryptominers or whatever that run on symmetry's repo.

In that case merging it should solve it.

Let me push some other things later this weekend then solve this.

skoppe commented 2 years ago

Great! nice.