symmetryinvestments / imap-d

D library for IMAP (JMAP is a work-in-progress but the basics work)
13 stars 10 forks source link

Bump openssl dependency to v3.1 #114

Closed kinke closed 2 years ago

kinke commented 2 years ago

Which doesn't compile with version OPENSSL_NO_SRP. AFAICT, we shouldn't define that anyway, as we seem to be making assumptions about how OpenSSL was built.

Also get rid of unconditionally defined version SSL and its single check.

codecov[bot] commented 2 years ago

Codecov Report

Merging #114 (1264cd4) into master (d16bea6) will increase coverage by 0.31%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   17.03%   17.34%   +0.31%     
==========================================
  Files          11       10       -1     
  Lines        1274     1251      -23     
==========================================
  Hits          217      217              
+ Misses       1057     1034      -23     
Impacted Files Coverage Δ
source/imap/auth.d 0.00% <0.00%> (ø)
source/imap/socket.d 0.00% <0.00%> (ø)
source/imap/request.d 0.00% <0.00%> (ø)
source/imap/system.d

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Geod24 commented 2 years ago

So the error we're seeing is because it's jumping straight to v3.0.0 and on Windows the detection script does not work. Should we constrain it to <3 or add a configuration ?

kinke commented 2 years ago

Okay, I've set it to use v1.1.1 on Windows - the latest version provided by Chocolatey at the moment: https://community.chocolatey.org/packages/openssl

Those versions are new in v3 AFAICT, so had to bump the min openssl version accordingly.

That said, imap-d master doesn't seem to compile with current SIL master. Sigh...

Geod24 commented 2 years ago

Looks good. Note that it won't compile if mixed with Vibe.d for the time being.

Geod24 commented 2 years ago

@skoppe : Can we get a merge ?