I reverted this because I think the reverted MR changes behaviour in a way that isn't helpful. The reason to stick UID before the FETCH etc is that way it uses the UID that won't change. Without the UID then it uses a message number that can change when you aren't expecting it - legacy behaviour maintained for reasons of backward compatibility.
In the event that this was what we wanted, a significant change like this should be a MR of it's own explaining the reason for and consequence of the changes. But if my memory serves me correctly this is not what we would want.
So please could you stick the UIDs back and resubmit the PR.
Reverts symmetryinvestments/imap-d#37
I reverted this because I think the reverted MR changes behaviour in a way that isn't helpful. The reason to stick UID before the FETCH etc is that way it uses the UID that won't change. Without the UID then it uses a message number that can change when you aren't expecting it - legacy behaviour maintained for reasons of backward compatibility.
In the event that this was what we wanted, a significant change like this should be a MR of it's own explaining the reason for and consequence of the changes. But if my memory serves me correctly this is not what we would want.
So please could you stick the UIDs back and resubmit the PR.
Thanks.