search

symmetryinvestments / imap-d

D library for IMAP (JMAP is a work-in-progress but the basics work)
14 stars 10 forks source link

Fix a bug with parsing strings to enums when getting capabilities dur… #67

Closed otrho closed 3 years ago

otrho commented 3 years ago

…ing login.

When parsing the response from CAPABILITIES we match the list returned from the server against a list of known capabilties which we store in an enum.

The enum has user defined attribute strings to match the server strings and we iteratively match them using a static foreach and __traits(getAttributes).

A recent compiler fix changed the way __traits(getAttributes) works with enums which broke our code.

codecov[bot] commented 3 years ago

Codecov Report

Merging #67 (65266e1) into master (80a1647) will increase coverage by 0.20%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #67      +/-   ##
=========================================
+ Coverage    8.21%   8.42%   +0.20%     
=========================================
  Files          10      10              
  Lines        1327    1294      -33     
=========================================
  Hits          109     109              
+ Misses       1218    1185      -33
Impacted Files Coverage Δ
source/imap/request.d 0.00% <0.00%> (ø)
source/imap/response.d 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 80a1647...65266e1. Read the comment docs.