symmetryinvestments / imap-d

D library for IMAP (JMAP is a work-in-progress but the basics work)
14 stars 10 forks source link

Replace sumtype with variant and other cleanups. #68

Closed otrho closed 3 years ago

otrho commented 3 years ago

This is Ilya's MR #64 with an extra commit to get the plugin to compile and test.

otrho commented 3 years ago

Hey @9il can you take a look at the commit I've added which updates register.d? I couldn't work out a better way to get the SIL functions to work with the newly const search query function args.

codecov[bot] commented 3 years ago

Codecov Report

Merging #68 (f52e889) into master (c89cae7) will decrease coverage by 0.56%. The diff coverage is 52.63%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #68      +/-   ##
=========================================
- Coverage    8.42%   7.85%   -0.57%     
=========================================
  Files          10      10              
  Lines        1294    1286       -8     
=========================================
- Hits          109     101       -8     
  Misses       1185    1185              
Impacted Files Coverage Δ
source/imap/namespace.d 0.00% <ø> (ø)
source/imap/session.d 0.00% <0.00%> (ø)
source/imap/set.d 0.00% <ø> (ø)
source/imap/searchquery.d 93.51% <100.00%> (-0.45%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c89cae7...f52e889. Read the comment docs.